fix(release): preserve canonical macOS app name#161
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 449456ce97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 3. Open T4 Code normally. The release workflow verifies the pinned publisher, hardened runtime, secure timestamp, Apple notarization, stapled ticket, and Gatekeeper acceptance before publication. | ||
| 4. To start terminal or CMUX sessions that can hand off to T4 Code, open **Settings → Hosts** and choose **Install t4-omp**. This adds `~/.local/bin/t4-omp` and leaves any existing `omp` command unchanged. | ||
|
|
||
| Upgrade note for v0.1.32 only: its DMG named the bundle `t4-code.app`. Before installing a |
There was a problem hiding this comment.
Correct the affected-release range
The lowercase bundle was not unique to v0.1.32: the top-level executableName: "t4-code" was already present in the first signed v0.1.24 configuration and remained through v0.1.31 with the same electron-builder version. Users upgrading from any of those releases will have /Applications/t4-code.app, but this v0.1.32-only instruction tells them the cleanup does not apply, leaving the old app alongside the corrected one. Broaden the migration note in the README, site docs, and release notes to cover all affected releases.
Useful? React with 👍 / 👎.
What this changes
t4-codeexecutable name to Linux so macOS packages the documentedT4 Code.appbundle andT4 Codeexecutablet4-code.appbundleThis prevents a normal macOS drag-install from creating a second application beside an existing
T4 Code.appinstallation.Risk and rollout
Low. Linux retains its existing
t4-codeexecutable name. macOS keeps the same bundle identifier, user-data location, signing identity, artifact filenames, and runtime contents; only the application bundle and main executable names now match the documented product name.Users who installed the v0.1.32 DMG must quit T4 Code and move
/Applications/t4-code.appto the Trash before copying the corrected app. The README, published install guide, and release notes carry that bounded migration guidance. New installations and upgrades from the canonical/Applications/T4 Code.apppath replace normally.Rollback is this commit before a corrected release tag is created.
How you verified it
pnpm test:packagingpassed: 51 tests after the new release-name guardpnpm checkpassed: release consistency, provenance, lint, and typecheckpnpm testpassed across all 18 workspacespnpm --filter @t4-code/site testpassed: 28 testspnpm --filter @t4-code/site buildpassedT4 Code.app,CFBundleExecutable=T4 Code, and an executableContents/MacOS/T4 CodeChecklist
pnpm checkpasses (release contract, provenance, lint, typecheck)pnpm testpasses; new behavior has a test that fails without this changeTHIRD_PARTY_NOTICES.md