Skip to content

fix(release): preserve canonical macOS app name#161

Merged
wolfiesch merged 1 commit into
mainfrom
codex/fix-mac-bundle-name
Jul 24, 2026
Merged

fix(release): preserve canonical macOS app name#161
wolfiesch merged 1 commit into
mainfrom
codex/fix-mac-bundle-name

Conversation

@wolfiesch

Copy link
Copy Markdown
Collaborator

What this changes

  • scope the lowercase t4-code executable name to Linux so macOS packages the documented T4 Code.app bundle and T4 Code executable
  • make protected macOS release inspection fail closed if either archive contains a differently named app bundle
  • document the one-time cleanup required for users who installed the misnamed v0.1.32 t4-code.app bundle

This prevents a normal macOS drag-install from creating a second application beside an existing T4 Code.app installation.

Risk and rollout

Low. Linux retains its existing t4-code executable name. macOS keeps the same bundle identifier, user-data location, signing identity, artifact filenames, and runtime contents; only the application bundle and main executable names now match the documented product name.

Users who installed the v0.1.32 DMG must quit T4 Code and move /Applications/t4-code.app to the Trash before copying the corrected app. The README, published install guide, and release notes carry that bounded migration guidance. New installations and upgrades from the canonical /Applications/T4 Code.app path replace normally.

Rollback is this commit before a corrected release tag is created.

How you verified it

  • pnpm test:packaging passed: 51 tests after the new release-name guard
  • pnpm check passed: release consistency, provenance, lint, and typecheck
  • pnpm test passed across all 18 workspaces
  • pnpm --filter @t4-code/site test passed: 28 tests
  • pnpm --filter @t4-code/site build passed
  • built an unsigned macOS DMG and ZIP with the pinned Node 24.13.1 and electron-builder 26.15.6
  • mounted/extracted both artifacts and verified T4 Code.app, CFBundleExecutable=T4 Code, and an executable Contents/MacOS/T4 Code
  • independent critical review found one legacy v0.1.32 migration gap; the documented cleanup above resolved it, and re-review found no remaining actionable issue

Checklist

  • pnpm check passes (release contract, provenance, lint, typecheck)
  • pnpm test passes; new behavior has a test that fails without this change
  • User-facing or architectural changes update the relevant docs, ADR, or release notes
  • Any pasted logs or screenshots are redacted: no secrets, tokens, pairing codes, or private paths
  • Ported code (T3 Code / OMP) follows the provenance rules in THIRD_PARTY_NOTICES.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 449456ce97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
3. Open T4 Code normally. The release workflow verifies the pinned publisher, hardened runtime, secure timestamp, Apple notarization, stapled ticket, and Gatekeeper acceptance before publication.
4. To start terminal or CMUX sessions that can hand off to T4 Code, open **Settings → Hosts** and choose **Install t4-omp**. This adds `~/.local/bin/t4-omp` and leaves any existing `omp` command unchanged.

Upgrade note for v0.1.32 only: its DMG named the bundle `t4-code.app`. Before installing a

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct the affected-release range

The lowercase bundle was not unique to v0.1.32: the top-level executableName: "t4-code" was already present in the first signed v0.1.24 configuration and remained through v0.1.31 with the same electron-builder version. Users upgrading from any of those releases will have /Applications/t4-code.app, but this v0.1.32-only instruction tells them the cleanup does not apply, leaving the old app alongside the corrected one. Broaden the migration note in the README, site docs, and release notes to cover all affected releases.

Useful? React with 👍 / 👎.

@wolfiesch
wolfiesch merged commit 3886cf5 into main Jul 24, 2026
10 checks passed
@wolfiesch
wolfiesch deleted the codex/fix-mac-bundle-name branch July 24, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant